Code-Review on Daffa Abhipraya

PPL: Code Review at Two Altitudes [Sprint 2, Week 3]

Wed, 15 Apr 2026 00:00:00 +0700

What I Worked On

Two weeks of code review on teammate MRs. Week 1 (2-8 Apr) covered three substantial MRs: hl’s CSV import modal (!155), hl’s settings management system (!128), and qenthm’s ML risk scoring engine (!166) — 44 review points including 7 P0s. Week 2 (9-15 Apr) covered fadhliraihan’s AR Staff read-only client access (!171) and fernanda.nadhiftya’s communication history UI (!177) — 6 review points including 2 P0s caught through manual testing that static reading missed. Fifty review points total, nine P0s, reviews posted as threaded discussions on every MR.

PPL: Communication and Knowledge Sharing [Sprint 2, Week 2]

Thu, 09 Apr 2026 00:00:00 +0700

Overview

Sprint 2 Week 2 (April 3 to 9) communication work centered on three substantial code reviews posted as GitLab discussion threads, merge coordination for 13+ teammate MRs, and Linear ticket management. The reviews caught several critical bugs that would have reached production, including a broken SQL join and an auth bypass.

1. Threaded MR Reviews with Severity Grading

Three MRs were reviewed this week, all following the same structured approach: positive callouts first, then issues grouped by severity (P0 blockers through P3 nitpicks), with code fix suggestions for every issue.

PPL: Communication and Knowledge Sharing [Sprint 2, Week 1]

Mon, 30 Mar 2026 00:00:00 +0700

Overview

Sprint 2 Week 1 (Mar 24 to 30) communication focused on two detailed code reviews posted as GitLab discussion threads, merge coordination for the team, and direct code contributions to address review findings.

1. Threaded MR Reviews with Severity Grading

This sprint I shifted to posting reviews as GitLab discussion threads rather than plain comments. Discussion threads can be individually resolved by the MR owner after addressing each issue, making it clear which feedback has been handled and which is still open.

PPL: Team Dev Management [Sprint 2, Week 2]

Mon, 30 Mar 2026 00:00:00 +0700

What I Worked On

Three substantial MRs reviewed this week: Bertrand’s cancel invoice feature (SIRA-125), Erdafa’s blue/green deployment system (SIRA-134 to SIRA-141), and Rifqi’s invoice grouping by status (SIRA-132). Total review points: 29 across P0/P1/P2/P3 severity.

MR !118 — Cancel Invoice Feature (Bertrand)

The implementation was solid on the happy path: TDD discipline visible from commit history, clean Router-Service-DB layering, rollback migration included. Review focused on API-level guard gaps that the frontend UI hid but the API did not enforce.

PPL: Ticket Quality as Code Review [Sprint 2, Week 1]

Mon, 23 Mar 2026 00:00:00 +0700

What I Worked On

This week’s review work had two dimensions: reviewing the ticket board for sync issues (a form of “code review” for project management), and letting SonarQube quality gates act as automated code review for the monitoring MR.

Ticket Board Audit

After creating 64 new tickets, I audited all 150+ active tickets (Backlog, Todo, In Progress, In Review) for contradictions and stale data. This is essentially code review applied to project planning.

PPL: Code Review [Sprint 1, Week 3]

Fri, 13 Mar 2026 00:00:00 +0700

What I Worked On

This week I reviewed 10 teammates’ merge requests, leaving substantive comments with code samples, performance suggestions, and architectural fixes. Three reviews included fix commits that I pushed directly to the teammate’s branch to unblock merging.

Review Summary

MR	Author	Feature	Review Type
!75	soydoradesu	Client management pages	Duplicate code + missing field
!72	hl	Dashboard stale data fix	TanStack Query invalidation gap
!64	soydoradesu	Frontend foundation	Comprehensive review + fix commits
!49	qenthm	Overdue detection worker	Consistency + naming review
!45	froklax	Staff management	Auth/DB desync risk
!46	adipppp	Auth deadlock fix	Correctness verification
!50	dafandikri	Dev environment fix	Review + 4 fix commits pushed
!40	soydoradesu	Frontend foundation	Cleanup commits pushed
!52	adipppp	Payment seeder	FK resolution review
!63	adipppp	JWT alg:none hardening	Security review

How I Conduct Code Reviews

Reviewing 10 MRs in a single week is only feasible because of a structured AI-assisted workflow. I use two Claude Code plugins depending on the MR type, then manually filter and post the findings.

PPL: Communication and Knowledge Sharing [Sprint 1, Week 3]

Tue, 10 Mar 2026 00:00:00 +0700

Overview

This week’s communication contributions fall into five categories: detailed code reviews, merge coordination, issue tracking, direct code contributions to teammates’ MRs, and proactive Discord communication to unblock the team.

1. Detailed Code Reviews with Actionable Fixes

Reviewed 15 MRs this week. Each review goes beyond surface-level “LGTM”: they include issue categorization (Critical/Important), before/after code snippets, and concrete suggested fixes that the MR owner can directly apply.

PPL: Code Review Across Architecture and Runtime Bugs [Sprint 1, Week 2]

Wed, 04 Mar 2026 00:00:00 +0700

Overview

MR	Feature	Issues
!10 - SIRA-31	Payment recording (dafandikri)	2
!12 - SIRA-30	Invoice management (froklax)	7
!17 - SIRA-29	Client management (fadhli)	1
!20 - SIRA-27	Layout and dashboard (haliza)	1

11 issues total. Each review included specific file and line references.

MR !10 - Payment Recording (2 issues)

Issue 1: .single() causes an unhandled 500 on missing records.

get_payment_by_id used .single() which throws PostgRESTError (PGRST116) when no row is found, making the if payment is None guard below it dead code. The fix is .maybe_single(), which returns None cleanly. The same fix was already applied in MR !23 for app_users.py.

Code-Review on Daffa Abhipraya

PPL: Code Review at Two Altitudes [Sprint 2, Week 3]

# What I Worked On

PPL: Communication and Knowledge Sharing [Sprint 2, Week 2]

# Overview

# 1. Threaded MR Reviews with Severity Grading

PPL: Communication and Knowledge Sharing [Sprint 2, Week 1]

# Overview

# 1. Threaded MR Reviews with Severity Grading

PPL: Team Dev Management [Sprint 2, Week 2]

# What I Worked On

# MR !118 — Cancel Invoice Feature (Bertrand)

PPL: Ticket Quality as Code Review [Sprint 2, Week 1]

# What I Worked On

# Ticket Board Audit

PPL: Code Review [Sprint 1, Week 3]

# What I Worked On

# Review Summary

# How I Conduct Code Reviews

PPL: Communication and Knowledge Sharing [Sprint 1, Week 3]

# Overview

# 1. Detailed Code Reviews with Actionable Fixes

PPL: Code Review Across Architecture and Runtime Bugs [Sprint 1, Week 2]

# Overview

# MR !10 - Payment Recording (2 issues)

What I Worked On

Overview

1. Threaded MR Reviews with Severity Grading

Overview

1. Threaded MR Reviews with Severity Grading

What I Worked On

MR !118 — Cancel Invoice Feature (Bertrand)

What I Worked On

Ticket Board Audit

What I Worked On

Review Summary

How I Conduct Code Reviews

Overview

1. Detailed Code Reviews with Actionable Fixes

Overview

MR !10 - Payment Recording (2 issues)